ICRC-122: ledger blocks recording management actions -- authorised mint, authorised burn blocks #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogwar
changed the title
bogwar
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
ICRCs/ICRC-122/ICRC-122.md:7
- There is a documentation inconsistency regarding account representation: line 7 specifies an array of two Value variants (using an empty Blob for no subaccount) while line 48 describes an array of one or two blobs. Please clarify and standardize the account format.
Accounts are recorded as an `Array` of two `Value` variants, where the first element is a `variant { Blob = <owner principal> }`, representing the account owner, and the second element is a `variant { Blob = <subaccount> }`, representing the subaccount.
mbjorkqvist
reviewed
Apr 8, 2025
marc0olo
reviewed
May 19, 2025
marc0olo
reviewed
May 19, 2025
marc0olo
reviewed
May 19, 2025
bogwar
commented
May 20, 2025
bogwar
commented
May 20, 2025
bogwar
commented
May 20, 2025
marc0olo
approved these changes
May 20, 2025
tmu0
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real World Asset ledgers require several management APIs that would allow authorised entities to carry out ledger changes. This standard introduces two new blocktypes:
122burnthat records tokens from an account were burned by an authorised party122mintthat records that tokens were minted to an account by an authorised party